Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window wrapper for safe GLFW tests #5375

Open
2 tasks done
Jacalz opened this issue Jan 8, 2025 · 0 comments
Open
2 tasks done

Add window wrapper for safe GLFW tests #5375

Jacalz opened this issue Jan 8, 2025 · 0 comments
Labels
blocker Items that would block a forthcoming release Driver:desktop Issues relating to the desktop driver specifically testing Issues related to tests and testing.

Comments

@Jacalz
Copy link
Member

Jacalz commented Jan 8, 2025

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

See discussion in #5372 (comment). We need to be extra careful when running the GLFW tests compared to the regular test runner. Instead of manually using the safe functions, it would be good to have them called automatically.

Is it possible to construct a solution with the existing API?

Yes

Describe the solution you'd like to see.

To make sure that we consistently use these safe functions and do not regress, we should try to implement a sort of wrapper around a regular window that extends methods and calls parent methods safely.

@Jacalz Jacalz added blocker Items that would block a forthcoming release Driver:desktop Issues relating to the desktop driver specifically testing Issues related to tests and testing. labels Jan 8, 2025
@Jacalz Jacalz added this to the "F" release, Early 2025 milestone Jan 8, 2025
@Jacalz Jacalz mentioned this issue Jan 8, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release Driver:desktop Issues relating to the desktop driver specifically testing Issues related to tests and testing.
Projects
None yet
Development

No branches or pull requests

1 participant