From d6c5c4a4e00d5a2c7b0da917af852b38e43270e6 Mon Sep 17 00:00:00 2001 From: Arjun Date: Fri, 17 Jan 2025 11:32:09 +0530 Subject: [PATCH] Add more trackers to mileage flow --- src/app/core/services/tracking.service.ts | 8 ++++++++ src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts | 4 ++++ src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts | 4 ++++ 3 files changed, 16 insertions(+) diff --git a/src/app/core/services/tracking.service.ts b/src/app/core/services/tracking.service.ts index a1f243439b..358e5c2f29 100644 --- a/src/app/core/services/tracking.service.ts +++ b/src/app/core/services/tracking.service.ts @@ -373,6 +373,14 @@ export class TrackingService { this.eventTrack('Edit Expense Error', properties); } + editMileageError(properties: { label: Error }): void { + this.eventTrack('Edit Mileage Error', properties); + } + + editPerDiemError(properties: { label: Error }): void { + this.eventTrack('Edit Per Diem Error', properties); + } + // adding expenses in existing report event addToExistingReport(properties = {}): void { this.eventTrack('Add Expenses to Report', properties); diff --git a/src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts b/src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts index f13f959c9f..79a5da7ebd 100644 --- a/src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts +++ b/src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts @@ -2651,6 +2651,10 @@ export class AddEditMileagePage implements OnInit { // NOTE: This double call is done as certain fields will not be present in return of upsert call. policy_amount in this case. return this.transactionService.upsert(etxn.tx as Transaction).pipe( + catchError((error: Error) => { + this.trackingService.editMileageError({ label: error }); + return throwError(() => error); + }), switchMap((txn) => this.expensesService.getExpenseById(txn.id)), map((expense) => this.transactionService.transformExpense(expense).tx), switchMap((tx) => { diff --git a/src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts b/src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts index 2dae6ea4c5..1ecb621cd8 100644 --- a/src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts +++ b/src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts @@ -2146,6 +2146,10 @@ export class AddEditPerDiemPage implements OnInit { } return this.transactionService.upsert(etxn.tx).pipe( + catchError((error: Error) => { + this.trackingService.editPerDiemError({ label: error }); + return throwError(() => error); + }), switchMap((txn) => this.expensesService.getExpenseById(txn.id)), map((expense) => this.transactionService.transformExpense(expense).tx), switchMap((tx) => {