diff --git a/src/app/core/mock-data/modal-controller.data.ts b/src/app/core/mock-data/modal-controller.data.ts index af2022b06c..997ae2e00d 100644 --- a/src/app/core/mock-data/modal-controller.data.ts +++ b/src/app/core/mock-data/modal-controller.data.ts @@ -102,6 +102,7 @@ export const enrollmentErrorPopoverData1 = { action: 'cancel', }, cardsList: {}, + leftAlign: true, }, component: PopupAlertComponent, cssClass: 'pop-up-in-center', @@ -123,6 +124,7 @@ export const enrollmentErrorPopoverData2 = { successfulCards: ['**** 1111'], failedCards: ['**** 1111'], }, + leftAlign: true, }, component: PopupAlertComponent, cssClass: 'pop-up-in-center', diff --git a/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.spec.ts b/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.spec.ts index c62f2425cf..d12a32f6c3 100644 --- a/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.spec.ts +++ b/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.spec.ts @@ -202,7 +202,7 @@ describe('SpenderOnboardingConnectCardStepComponent', () => { expect(component.cardsEnrolling).toBeTrue(); }); - it('should call enrollMultipleCards if enrollableCards has items', () => { + it('should call enrollMultipleCards if enrollableCards has items - case when there are no items', () => { const enrollSingularCardSpy = spyOn(component, 'enrollSingularCard'); const enrollMultipleCardsSpy = spyOn(component, 'enrollMultipleCards'); component.ngOnInit(); @@ -214,9 +214,9 @@ describe('SpenderOnboardingConnectCardStepComponent', () => { component.enrollCards(); - expect(enrollMultipleCardsSpy).toHaveBeenCalledWith([component.enrollableCards[1]]); + expect(enrollMultipleCardsSpy).not.toHaveBeenCalled(); expect(enrollSingularCardSpy).not.toHaveBeenCalled(); - expect(component.cardsEnrolling).toBeTrue(); + expect(component.cardsEnrolling).toBeFalse(); }); it('should call enrollSingularCard if enrollableCards is empty', () => { @@ -364,6 +364,10 @@ describe('SpenderOnboardingConnectCardStepComponent', () => { }); it('should display a popover when successful cards are present and handle its actions', fakeAsync(() => { + component.cardsList = { + successfulCards: ['**** 1111'], + failedCards: ['**** 1111'], + }; const popoverSpy = jasmine.createSpyObj('popover', ['present', 'onWillDismiss']); spyOn(component, 'generateMessage').and.returnValue('Error message'); const isStepSkippedSpy = spyOn(component.isStepSkipped, 'emit'); diff --git a/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.ts b/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.ts index 69de68c7c2..da25fe00aa 100644 --- a/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.ts +++ b/src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.ts @@ -130,7 +130,7 @@ export class SpenderOnboardingConnectCardStepComponent implements OnInit, OnChan } else if (this.cardsList.failedCards.length > 1) { const allButLast = this.cardsList.failedCards.slice(0, -1).join(', '); const lastCard = this.cardsList.failedCards[this.cardsList.failedCards.length - 1]; - return `We ran into an issue while processing your request for the cards ${allButLast}} and ${lastCard}.

You can cancel and retry connecting the failed card or proceed to the next step.`; + return `We ran into an issue while processing your request for the cards ${allButLast} and ${lastCard}.

You can cancel and retry connecting the failed card or proceed to the next step.`; } else { return `We ran into an issue while processing your request for the card ${this.cardsList.failedCards[0]}.

You can cancel and retry connecting the failed card or proceed to the next step.`; }