Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI builds do not fail on errors in cljs tests #158

Closed
sfnelson opened this issue Feb 29, 2016 · 1 comment
Closed

CI builds do not fail on errors in cljs tests #158

sfnelson opened this issue Feb 29, 2016 · 1 comment

Comments

@sfnelson
Copy link
Contributor

See https://travis-ci.org/funcool/cats/jobs/111481597

I've fixed this particular failure in my merge request for #157 but you probably want to address your ci scripts so that they won't pass on failing tests.
@sfnelson sfnelson changed the title Jenkins builds do not fail on errors in cljs tests CI builds do not fail on errors in cljs tests Feb 29, 2016
yurrriq added a commit that referenced this issue Mar 1, 2016
@yurrriq
Update test/cats/runner.cljs
6bd186c 
The cljs tests should fail for this commit.

- Cosmetic tweaks
- Rename main to -main
- Use when-not and (aget js/process "exit")
  instead of (set! (.-exitCode js/process) n)

See #158
@yurrriq
Copy link
Collaborator

yurrriq commented Mar 1, 2016

Fixed in #159. See 6bd186c failures, for example.

@yurrriq yurrriq closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfnelson @yurrriq