Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not re-import keys for sources that already have them #735

Closed
eloquence opened this issue Jan 27, 2020 · 1 comment · Fixed by #749
Closed

Do not re-import keys for sources that already have them #735

eloquence opened this issue Jan 27, 2020 · 1 comment · Fixed by #749

Comments

@eloquence
Copy link
Member

eloquence commented Jan 27, 2020

Due to this logic, after each sync, we attempt to re-import every key for every source from the server. There is no need to re-import keys we already have, as a source can not change their keypair except by logging in as a new source.

This unnecessary re-import can cause performance issues when using the client with a large number of sources and should be resolved as part of mitigation for #716.

(Copied in part from @redshiftzero's comment here: #733 (comment))

@eloquence eloquence added this to the 0.2.0beta milestone Jan 29, 2020
@eloquence
Copy link
Member Author

eloquence commented Jan 29, 2020

@rmol this was removed from #733 per this comment, could you create a separate PR for it? It's still worth doing for beta if it shaves off a few seconds when using >200 sources. Not release blocker level but I think we should keep it on the milestone (unless there any negative side-effects I'm not aware of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant