Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to skip getDepotLocation and changesOnDepot #5

Open
JayBazuzi opened this issue Mar 5, 2018 · 2 comments
Open

Add options to skip getDepotLocation and changesOnDepot #5

JayBazuzi opened this issue Mar 5, 2018 · 2 comments

Comments

@JayBazuzi
Copy link
Contributor

These can be slow, especially for very large depots.

@fredericrous
Copy link
Owner

fredericrous commented Mar 5, 2018

Yes it is slow, but removing these two options would have the same effect as not including the prompt, would it not?
I could add a note in the readme regarding the performance issue.

The solution I see to solve this performance issue would be to make a C# dll especially dedicated to check depot location and changes in a background task...and of course signal in the prompt when data are still waiting info back from the dll..
I never took the time to make this improvement, and I do not use p4 on a daily basis like I used to.
I would recommend to use the posh-p4 package not for its prompt but for the p4 autocompletion

EDIT: I just saw you made PRs I will review them =) thank you

@JayBazuzi
Copy link
Contributor Author

Thanks.

While getDepotLocation and changesOnDepot are slow, pendingStatus is fast and still useful.

I'll look in to sending a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants