Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PDF generation #18

Open
fraxken opened this issue Jan 29, 2023 · 3 comments
Open

Improve PDF generation #18

fraxken opened this issue Jan 29, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@fraxken
Copy link
Owner

fraxken commented Jan 29, 2023

Hello 👋

We recently finished to re-orders chapters for both english and french versions. However PDF generation is currently not that great:

  • Broken links between chapters
  • Doesn't render emojis very well
  • Code highligh is not great either
  • Image doesn't load
@fraxken fraxken added the good first issue Good for newcomers label Jan 29, 2023
@fraxken fraxken mentioned this issue Jan 29, 2023
Closed
@Shaju06
Copy link

Shaju06 commented Mar 26, 2023

Hi,
Can I work on this issue?

@fraxken
Copy link
Owner Author

fraxken commented Mar 26, 2023

Hi @Shaju06, yes you can work on it!

@Rossb0b
Copy link
Contributor

Rossb0b commented Nov 25, 2023 •
edited
Loading

@fraxken To fix redirection inside the document, here is a solution.

image
image

but at this point, the MD links overwrite the href="#Introduction", so using the class Introduction-ref (as there is multiple redirections to the hyperlinks), it is possible to rematch on hyperlinks.

This way, it's possible to have the md and the pdf redirection.

For the rest, #27 resolved points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fraxken @Rossb0b @Shaju06