[#5156] Add dialog for splitting items in inventory into two stacks #5157
+210
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "Split Stack" context menu option for an item that has a quantity of at least 2. Contains a modified version of core's `<range-picker>` element that has a number input on the left side. This modified element won't be required if foundryvtt/foundryvtt#12147 is resolved. Closes #5156
krbz999
reviewed
Feb 10, 2025
| const right = formData.object.right ?? 0; | ||
| const left = (this.options.document.system.quantity ?? 1) - right; | ||
| if ( left === this.options.document.system.quantity ) return; | ||
| await this.options.document.update({ "system.quantity": left }, { render: false }); |
There was a problem hiding this comment.
Is render: false to prevent the actor sheet rendering twice? This would prevent the item sheet rendering too, though. So maybe just Promise.all like is done with advancements? (Or swap the order of operations here.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Split Stack" context menu option for an item that has a quantity of at least 2. Contains a modified version of core's
<range-picker>element that has a number input on the left side. This modified element won't be required iffoundryvtt/foundryvtt#12147 is resolved.
Closes #5156