-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge this fork into foodcoops/foodsoft #163
Comments
I'm experimenting with rewriting the member ordering pages in React, which makes it all a lot cleaner. |
See foodsoft-shop repository for revamped member ordering pages in progress. |
Aha, is this still a focus? I just posted http://foodsoft.51229.x6.nabble.com/Status-on-foodcoop-adam-foodsoft-fork-td2748.html and now I see this ;) Well, I am doing a lot of internet stalking on you all 🔥 |
@wvengen As per the recent zoom discussion: which items of the above list should we transfer to the foodcoops/foodsoft issue list as features to be added upstream? |
@RayOei I think that #187 is the most important (which I would say, depends on foodcoops#1073 which I need to find time to review, to determine the next steps). If you want the foodcoop-adam member ordering interface, this is implemented in https://github.com/foodcoops/foodsoft-shop and already work with the global hosting (after a bit of setup), except that members cannot click through to it from Foodsoft :( This was meant to be fixed by foodcoops#581 but this proposal was rejected. What may still be accepted, is to not include the Javascript bundle into Foodsoft, but have a config option pointing to where foodsoft-shop is hosted (plain files somewhere, could even be gh-pages). I think Foodcoop Noord used a feature where members could order, and only have the member orders be included after they were payed. That is not implemented in Foodsoft, and I don't think it will happen soon (it required quite deep changes, that I'm not sure are actually a good idea as it was implemented). I think there are ways to work around this, e.g. set a minimum account balance, so that a first order cannot be too large without initial payment (with online payments using Mollie, these are now available in the global hosting, if I understand it correctly). Note that self-service signup is also not present in upstream Foodsoft. This adds a little extra step in the onboarding process, I'm afraid, but could that be acceptable? This is something that could be accepted into upstream Foodsoft, I think. |
This fork has quite diverged from upstream, unfortunately. It's time to merge the features back there, which is also a good opportunity to implement them in a clean(er) way. This is a meta-issue to gather everything that needs to be done, before foodcoops using this fork can transition to upstream.
Minimum required:
(now integrated with bank accounts?)(fc-ocnoord, uk request) -> see this branch, plugin got merged in 1008 ideal integration online payment provider foodcoops/foodsoft#1031Figure out how we could do without:
What is being used but may be omitted or postponed (check with coops):
What we can omit (because it isn't used anymore):
The text was updated successfully, but these errors were encountered: