From e2c4b45f7f34310290a7d9bcfc29a6b28f0d2c50 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?=
 <juca@members.fsf.org>
Date: Wed, 27 Mar 2024 04:03:11 -0300
Subject: [PATCH] we won't run code-tests on PASS messages anymore

because PASS results should be kept simple, with a default generic message.

(issue #4612)
---
 Lib/fontbakery/codetesting.py      | 2 --
 tests/checks/opentype/name_test.py | 8 +++++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Lib/fontbakery/codetesting.py b/Lib/fontbakery/codetesting.py
index 0ead9974c7..7738efb866 100644
--- a/Lib/fontbakery/codetesting.py
+++ b/Lib/fontbakery/codetesting.py
@@ -188,10 +188,8 @@ def assert_PASS(check_results, reason="with a good font...", ignore_error=None):
 
     if ignore_error and subresult.status == ERROR:
         print(ignore_error)
-        return None
     else:
         assert subresult.status == PASS
-        return str(subresult.message)
 
 
 def assert_SKIP(check_results, reason=""):
diff --git a/tests/checks/opentype/name_test.py b/tests/checks/opentype/name_test.py
index 4c7f974684..cab04ef380 100644
--- a/tests/checks/opentype/name_test.py
+++ b/tests/checks/opentype/name_test.py
@@ -11,6 +11,7 @@
     MacintoshLanguageID,
 )
 from fontbakery.message import Message
+from fontbakery.result import Subresult
 from fontbakery.status import INFO, WARN, PASS, FAIL, SKIP, DEBUG
 from fontbakery.codetesting import (
     assert_PASS,
@@ -332,7 +333,12 @@ def assert_name_table_check_result(
     # set value
     ttFont["name"].names[index].string = value.encode(name.getEncoding())
     # run check
-    subresult = check(ttFont)[-1]
+    subresults = check(ttFont)
+    if [sr for sr in subresults if sr.status not in [INFO, DEBUG]] == []:
+        subresult = Subresult(PASS, Message("ok", "All looks good!"))
+    else:
+        subresult = subresults[-1]
+
     status, message = subresult.status, subresult.message
     # restore value
     ttFont["name"].names[index].string = backup