Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning generated by VS17.4 related to formattable concept #4354

Closed
wants to merge 1 commit into from
+3 −3
Closed

Fix warning generated by VS17.4 related to formattable concept #4354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/fmt/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,10 +1650,10 @@ template <typename T, typename Char>
FMT_VISIBILITY("hidden") // Suppress an ld warning on macOS (#3769).
FMT_CONSTEXPR auto invoke_parse(parse_context<Char>& ctx) -> const Char* {
using mapped_type = remove_cvref_t<mapped_t<T, Char>>;
constexpr bool formattable =
constexpr bool can_format =
std::is_constructible<formatter<mapped_type, Char>>::value;
if (!formattable) return ctx.begin(); // Error is reported in the value ctor.
using formatted_type = conditional_t<formattable, mapped_type, int>;
if (!can_format) return ctx.begin(); // Error is reported in the value ctor.
using formatted_type = conditional_t<can_format, mapped_type, int>;
return formatter<formatted_type, Char>().parse(ctx);
}

Expand Down
Loading