Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of Swift Package Manager #3841

Closed
wants to merge 1 commit into from

Conversation

IhorShevchuk
Copy link

This allows to add fmt as dependency to other Swift Packages or Xcode projects

This allows to add fmt as dependency to other Swift Packages or Xcode projects
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we could add a new package config but please put in the support directory where other contributed build/package configs reside.

@vitaut
Copy link
Contributor

vitaut commented Feb 13, 2024

@IhorShevchuk, do you plan to update this PR?

@IhorShevchuk
Copy link
Author

Hi @vitaut, sorry about the delay. Unfortunately Package.swift file must be located in root directory of the repository in order to other packages can see it and use.
I'll add documentation how to use it in another Swift Package or Xcode in support/spm folder. Also I guess it is a good idea to add build step in workflow

@vitaut
Copy link
Contributor

vitaut commented Feb 13, 2024

We shouldn't create an exception for Swift package manager so there are two options:

  1. Put Package.swift in support/spm together with instructions/script how to move it - this is what we do for Bazel.
  2. Create a separate repo with Package.swift in the top-level directory and fmt in a subdirectory, possibly as a submodule - this is similar to what most package managers do.

@IhorShevchuk
Copy link
Author

I see, than I would go with second option and create separate repository for fmt with Swift Package Manager.
Thanks! I'll close this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants