static_cast<unsigned>(id)

fmtlib · Apr 30, 2024 · 58c6ecc · 58c6ecc
1 parent a8f522b
commit 58c6ecc
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/include/fmt/base.h b/include/fmt/base.h
@@ -1899,12 +1899,10 @@ template <typename Context> class basic_format_args {
       if (id < max_size()) arg = args_[id];
       return arg;
     }
-    if (id >= detail::max_packed_args) return arg;
+    if (static_cast<unsigned>(id) >= detail::max_packed_args) return arg;
     arg.type_ = type(id);
     if (arg.type_ == detail::type::none_type) return arg;
-    if (id >= 0) {
-      arg.value_ = values_[id];
-    }
+    arg.value_ = values_[id];
     return arg;
   }