Skip to content

Commit

Permalink
Fix warning generated by VS17.4
Browse files Browse the repository at this point in the history
In VS17.4, the `formattable` local variable hides a concept of the same name. This causes a C4459 warning to be triggered. Renaming the local variable fixes the warning.
  • Loading branch information
dinomight authored Feb 20, 2025
1 parent 94ab51c commit 05c9fb1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions include/fmt/base.h
Original file line number Diff line number Diff line change
Expand Up @@ -1650,10 +1650,10 @@ template <typename T, typename Char>
FMT_VISIBILITY("hidden") // Suppress an ld warning on macOS (#3769).
FMT_CONSTEXPR auto invoke_parse(parse_context<Char>& ctx) -> const Char* {
using mapped_type = remove_cvref_t<mapped_t<T, Char>>;
constexpr bool formattable =
constexpr bool can_format =
std::is_constructible<formatter<mapped_type, Char>>::value;
if (!formattable) return ctx.begin(); // Error is reported in the value ctor.
using formatted_type = conditional_t<formattable, mapped_type, int>;
if (!can_format) return ctx.begin(); // Error is reported in the value ctor.
using formatted_type = conditional_t<can_format, mapped_type, int>;
return formatter<formatted_type, Char>().parse(ctx);
}

Expand Down

0 comments on commit 05c9fb1

Please sign in to comment.