From b040d05d5300aee3d79ac43276888ca3e5a229c9 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 12:37:56 +0530 Subject: [PATCH 01/23] add gh workflow to test doc generation Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 65920adf3..df7172783 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -220,3 +220,18 @@ jobs: path: ./gen - name: Test run: ./scripts/test_diff.sh + + test-docs: + runs-on: ubuntu-latest + name: Test Docs + steps: + - name: Checkout + uses: actions/checkout@v2 + with: + fetch-depth: "0" + - name: "Set up Docker" + uses: docker-practice/actions-setup-docker@master + - name: "Generate Docs" + run: make download_tooling && make generate + - name: "Test Docs" + run: ./scripts/test_diff.sh \ No newline at end of file From 7c2741a1c28a84d783a09e00e1fab23f4c28c2d3 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 12:49:05 +0530 Subject: [PATCH 02/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index df7172783..66cfb7a90 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -229,9 +229,11 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: "0" - - name: "Set up Docker" + - name: Set up Docker uses: docker-practice/actions-setup-docker@master - - name: "Generate Docs" + - name: Go + uses: cedrickring/golang-action@1.7.0 + - name: Generate Docs run: make download_tooling && make generate - - name: "Test Docs" + - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From dfab37950166e3213003aa0179bcd375fa9453c9 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 12:53:06 +0530 Subject: [PATCH 03/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 66cfb7a90..6466a67a3 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -233,6 +233,8 @@ jobs: uses: docker-practice/actions-setup-docker@master - name: Go uses: cedrickring/golang-action@1.7.0 + env: + GO111MODULE: "on" - name: Generate Docs run: make download_tooling && make generate - name: Test Docs From ac96810933068f13a0d8f6affc15374590582292 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 13:01:24 +0530 Subject: [PATCH 04/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 6466a67a3..a988f6c01 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -235,7 +235,7 @@ jobs: uses: cedrickring/golang-action@1.7.0 env: GO111MODULE: "on" - - name: Generate Docs - run: make download_tooling && make generate + with: + args: make download_tooling && make generate - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 9ad91c6b48008a9d9d9e0cae59a9aed66385dc6e Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 13:27:24 +0530 Subject: [PATCH 05/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index a988f6c01..61d5867fe 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -224,18 +224,17 @@ jobs: test-docs: runs-on: ubuntu-latest name: Test Docs + needs: [generate-swagger-code] steps: - name: Checkout uses: actions/checkout@v2 with: fetch-depth: "0" - - name: Set up Docker - uses: docker-practice/actions-setup-docker@master - name: Go uses: cedrickring/golang-action@1.7.0 env: GO111MODULE: "on" with: - args: make download_tooling && make generate + args: make generate - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 04664b53b642cefa65e4dfe02e4bc634fdb74bbe Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 13:54:08 +0530 Subject: [PATCH 06/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 61d5867fe..ccd981009 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -225,16 +225,22 @@ jobs: runs-on: ubuntu-latest name: Test Docs needs: [generate-swagger-code] + container: + image: lyft/protocgenerator:8167e11d3b3439373c2f033080a4b550078884a2 + options: --cpus 1 + volumes: + - /github/workspace:/defs + env: + REPO_BLOB_SHA: master + PROJECT_ANNOTATION_PREFIX: flyte.interface steps: - name: Checkout uses: actions/checkout@v2 with: fetch-depth: "0" - - name: Go - uses: cedrickring/golang-action@1.7.0 - env: - GO111MODULE: "on" - with: - args: make generate + - name: Generate Docs + run: core_proto_files=`ls protos/flyteidl/core/*.proto |xargs` + run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm + run: python3 /usr/local/bin/entrypoint.py protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 57ca98a127474cb225f4837a0e21019a3ff6e875 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 13:55:18 +0530 Subject: [PATCH 07/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index ccd981009..f4e9171bb 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -224,7 +224,6 @@ jobs: test-docs: runs-on: ubuntu-latest name: Test Docs - needs: [generate-swagger-code] container: image: lyft/protocgenerator:8167e11d3b3439373c2f033080a4b550078884a2 options: --cpus 1 @@ -238,9 +237,9 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: "0" + - run: core_proto_files=`ls protos/flyteidl/core/*.proto |xargs` + - run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm - name: Generate Docs - run: core_proto_files=`ls protos/flyteidl/core/*.proto |xargs` - run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm run: python3 /usr/local/bin/entrypoint.py protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From e40faccd951fbb80030d725c6b8d0aed3defc972 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 14:06:19 +0530 Subject: [PATCH 08/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index f4e9171bb..15333284a 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -238,7 +238,9 @@ jobs: with: fetch-depth: "0" - run: core_proto_files=`ls protos/flyteidl/core/*.proto |xargs` - - run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm + - name: Clean Generated + run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm + continue-on-error: true - name: Generate Docs run: python3 /usr/local/bin/entrypoint.py protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto - name: Test Docs From 11b79c7c3ec79f24cb320c4fc32e81e93bea8760 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 14:10:00 +0530 Subject: [PATCH 09/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 15333284a..8a5731c55 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -241,7 +241,9 @@ jobs: - name: Clean Generated run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm continue-on-error: true + - name: Install Protoc + uses: arduino/setup-protoc@v1 - name: Generate Docs - run: python3 /usr/local/bin/entrypoint.py protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto + run: protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 8c74584927fc1aeaa0625b6dd666446fbb9613cf Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:15:02 +0530 Subject: [PATCH 10/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 8a5731c55..4235ade87 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -225,13 +225,8 @@ jobs: runs-on: ubuntu-latest name: Test Docs container: - image: lyft/protocgenerator:8167e11d3b3439373c2f033080a4b550078884a2 + image: pseudomuto/protoc-gen-doc options: --cpus 1 - volumes: - - /github/workspace:/defs - env: - REPO_BLOB_SHA: master - PROJECT_ANNOTATION_PREFIX: flyte.interface steps: - name: Checkout uses: actions/checkout@v2 From 7dccbe0342dbdd826e39ecdda823c1109c1eaa43 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:19:12 +0530 Subject: [PATCH 11/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 4235ade87..b9ec54a34 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -236,8 +236,6 @@ jobs: - name: Clean Generated run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm continue-on-error: true - - name: Install Protoc - uses: arduino/setup-protoc@v1 - name: Generate Docs run: protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto - name: Test Docs From f1ab9395bad0d6ce5afa7537e2044be00925ad98 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:41:27 +0530 Subject: [PATCH 12/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index b9ec54a34..fd169e35f 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -232,11 +232,9 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: "0" - - run: core_proto_files=`ls protos/flyteidl/core/*.proto |xargs` - - name: Clean Generated - run: ls -d protos/docs/core/* | grep -v index.rst | xargs rm - continue-on-error: true + - name: Setup Docker + uses: docker-practice/actions-setup-docker@master - name: Generate Docs - run: protoc --doc_out=protos/docs/core --doc_opt=restructuredtext,core.rst -I=tmp/doc_gen_deps -I=protos `echo $core_proto_files` tmp/doc_gen_deps/google/protobuf/timestamp.proto tmp/doc_gen_deps/google/protobuf/duration.proto tmp/doc_gen_deps/google/protobuf/struct.proto + uses: make generate - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 927cd7ea8c42c57dcf08865284072b26f70a1ea5 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:44:07 +0530 Subject: [PATCH 13/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index fd169e35f..7d1244f33 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -232,8 +232,7 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: "0" - - name: Setup Docker - uses: docker-practice/actions-setup-docker@master + - uses: docker-practice/actions-setup-docker@master - name: Generate Docs uses: make generate - name: Test Docs From 0c9073b7837612ed82d6ae7931b1b419c80c4d1b Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:44:41 +0530 Subject: [PATCH 14/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 7d1244f33..7d5178bb6 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -232,8 +232,9 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: "0" - - uses: docker-practice/actions-setup-docker@master + - name: Setup Docker + uses: docker-practice/actions-setup-docker@master - name: Generate Docs - uses: make generate + run: make generate - name: Test Docs run: ./scripts/test_diff.sh \ No newline at end of file From 621504dc3c649b9699263364da40846e85012ed0 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 15:57:16 +0530 Subject: [PATCH 15/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 7d5178bb6..2a9946e37 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -224,15 +224,17 @@ jobs: test-docs: runs-on: ubuntu-latest name: Test Docs - container: - image: pseudomuto/protoc-gen-doc - options: --cpus 1 steps: + - name: "Set up Go" + uses: actions/setup-go@v2 + with: + go-version: 1.14 + - run: go get -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc - name: Checkout uses: actions/checkout@v2 with: fetch-depth: "0" - - name: Setup Docker + - name: Set up Docker uses: docker-practice/actions-setup-docker@master - name: Generate Docs run: make generate From 9c416467875a1d84915206382d02bbce5a84f20b Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 16:01:49 +0530 Subject: [PATCH 16/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 2a9946e37..1ca01cc59 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -226,9 +226,9 @@ jobs: name: Test Docs steps: - name: "Set up Go" - uses: actions/setup-go@v2 + uses: actions/setup-go@v3 with: - go-version: 1.14 + go-version: 1.17.0 - run: go get -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc - name: Checkout uses: actions/checkout@v2 From 371b2da36cffc656b8a90af965b80623b66c2d65 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 17:45:54 +0530 Subject: [PATCH 17/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 1ca01cc59..0c0e45ab9 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -228,7 +228,7 @@ jobs: - name: "Set up Go" uses: actions/setup-go@v3 with: - go-version: 1.17.0 + go-version: 1.16.0 - run: go get -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc - name: Checkout uses: actions/checkout@v2 From 26e9955aa3239bb5418032e74e00d6b72516954e Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 17:55:54 +0530 Subject: [PATCH 18/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 0c0e45ab9..85e79e19e 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -228,8 +228,9 @@ jobs: - name: "Set up Go" uses: actions/setup-go@v3 with: - go-version: 1.16.0 - - run: go get -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc + go-version: 1.17.0 + - run: go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc + - run: protoc --version - name: Checkout uses: actions/checkout@v2 with: From e573b4c3403113bb9db46b93196662d1753fc625 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 17:58:49 +0530 Subject: [PATCH 19/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 85e79e19e..3b39412d1 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -229,7 +229,7 @@ jobs: uses: actions/setup-go@v3 with: go-version: 1.17.0 - - run: go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc + - run: go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest - run: protoc --version - name: Checkout uses: actions/checkout@v2 From 0f27243aa3b4626e03203f92cfd65fca0a5a649a Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 18:25:45 +0530 Subject: [PATCH 20/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 3b39412d1..faf566e53 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -229,8 +229,10 @@ jobs: uses: actions/setup-go@v3 with: go-version: 1.17.0 - - run: go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest - - run: protoc --version + - run: | + export PATH=$PATH:$(go env GOPATH)/bin + go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest + protoc --version - name: Checkout uses: actions/checkout@v2 with: From 2d59c79081b9663849d4eb3e4caad2a859877430 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 18:26:27 +0530 Subject: [PATCH 21/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index faf566e53..ed92ea8f9 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -230,9 +230,9 @@ jobs: with: go-version: 1.17.0 - run: | - export PATH=$PATH:$(go env GOPATH)/bin - go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest - protoc --version + export PATH=$PATH:$(go env GOPATH)/bin + go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest + protoc --version - name: Checkout uses: actions/checkout@v2 with: From 6f061a36979a0a3dd1a4288b14607d2afa82f0e6 Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 18:46:24 +0530 Subject: [PATCH 22/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index ed92ea8f9..1e6321237 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -230,8 +230,8 @@ jobs: with: go-version: 1.17.0 - run: | - export PATH=$PATH:$(go env GOPATH)/bin go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest + echo $PATH protoc --version - name: Checkout uses: actions/checkout@v2 From 2c354eba0cc5e26b2700dc036d28ecee3c10649d Mon Sep 17 00:00:00 2001 From: Samhita Alla Date: Fri, 8 Apr 2022 18:53:27 +0530 Subject: [PATCH 23/23] fixes Signed-off-by: Samhita Alla --- .github/workflows/verification.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verification.yml b/.github/workflows/verification.yml index 1e6321237..89902e741 100644 --- a/.github/workflows/verification.yml +++ b/.github/workflows/verification.yml @@ -231,6 +231,7 @@ jobs: go-version: 1.17.0 - run: | go install github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc@latest + export PATH=${PATH}:`go env GOPATH`/bin echo $PATH protoc --version - name: Checkout