Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated code from codecov reports #6299

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Mar 3, 2025

Tracking issue

NA

Why are the changes needed?

The overal numbers in https://app.codecov.io/gh/flyteorg/flyte are brought down by the proto stubs generated as part of flyteidl build process and also the mocks produced by mockery. Let's ignore those in codecov reports.

What changes were proposed in this pull request?

As defined in https://docs.codecov.com/docs/ignoring-paths, we can ignore a folder by using the patter folder/**/*. We use this pattern to ignore all generated code under flyteidl/gen.

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.49%. Comparing base (22eaeab) to head (04a902e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6299       +/-   ##
===========================================
+ Coverage   33.82%   58.49%   +24.67%     
===========================================
  Files        1329      937      -392     
  Lines      147835    71088    -76747     
===========================================
- Hits        50004    41583     -8421     
+ Misses      92989    26353    -66636     
+ Partials     4842     3152     -1690     
Flag Coverage Δ
unittests-datacatalog 59.06% <ø> (+11.05%) ⬆️
unittests-flyteadmin 56.30% <ø> (+6.19%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (+6.56%) ⬆️
unittests-flyteidl 76.12% <ø> (+69.33%) ⬆️
unittests-flyteplugins 61.00% <ø> (+11.98%) ⬆️
unittests-flytepropeller 54.79% <ø> (+18.26%) ⬆️
unittests-flytestdlib 64.04% <ø> (+13.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario enabled auto-merge (squash) March 3, 2025 22:03
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 5e3a4e9 into master Mar 3, 2025
50 checks passed
@eapolinario eapolinario deleted the ignore-flyteidl-gen-code-in-codecov branch March 3, 2025 22:17
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants