Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto refresh cache tweaks #5759

Closed
wants to merge 4 commits into from
Closed

Auto refresh cache tweaks #5759

wants to merge 4 commits into from

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Sep 18, 2024

Tracking issue

Why are the changes needed?

Items remain in the LP admin cache in a terminal state until they are evicted based on LRU policy. This causes for more cache evictions than necessary.

What changes were proposed in this pull request?

  • Update subworkflow nodes to set cached lp status items to be deleted in auto refresh cache during Finalize

How was this patch tested?

  • tested in sandbox
  • TODO: add unit test...

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 36.28%. Comparing base (2d9c35b) to head (6b62c9f).
Report is 255 commits behind head on master.

Files with missing lines Patch % Lines
...ler/nodes/subworkflow/launchplan/mocks/executor.go 0.00% 16 Missing ⚠️
.../nodes/subworkflow/launchplan/mocks/flyte_admin.go 0.00% 16 Missing ⚠️
...ler/pkg/controller/nodes/subworkflow/launchplan.go 0.00% 11 Missing ⚠️
...peller/pkg/controller/nodes/subworkflow/handler.go 0.00% 6 Missing ⚠️
...g/controller/nodes/subworkflow/launchplan/admin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5759      +/-   ##
==========================================
- Coverage   36.30%   36.28%   -0.02%     
==========================================
  Files        1305     1305              
  Lines      109997   110045      +48     
==========================================
- Hits        39930    39927       -3     
- Misses      65911    65962      +51     
  Partials     4156     4156              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.62% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.80% <0.00%> (-0.09%) ⬇️
unittests-flytestdlib 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt force-pushed the refresh-caching-perf branch from d15920e to e3a0fe4 Compare September 18, 2024 22:18
Signed-off-by: Paul Dittamo <[email protected]>
@eapolinario
Copy link
Contributor

Cleaning stale PRs. Please reopen if you wan to discuss this further.

@eapolinario eapolinario closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants