-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowedAudience to flyte-core external auth deployment documentation #5124
Add allowedAudience to flyte-core external auth deployment documentation #5124
Conversation
Signed-off-by: Mark Waylonis <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5124 +/- ##
===========================================
- Coverage 59.00% 33.82% -25.19%
===========================================
Files 645 1329 +684
Lines 55672 147814 +92142
===========================================
+ Hits 32850 49994 +17144
- Misses 20226 92978 +72752
- Partials 2596 4842 +2246
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Congrats on merging your first pull request! 🎉 |
Code Review Agent Run #d75807Actionable Suggestions - 0Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Why are the changes needed?
This adds documentation to the auth config for flyte-core deployments with Okta. In the case where flyteadmin is running in the same cluster as flytepropeller/flytescheduler, the authentication request from flytescheduler to flyteadmin is made using
http://flyteadmin:80
. flyteadmin uses the domain in the request to validate the audience in the JWT returned by okta (code reference). This causes a mismatch between the JWT audience and the expectedAudience when the auth request originates from flytescheduler within the same cluster. TheallowedAudience
setting takes precedence over the URL extracted from the request, so setting this property in the values file fixes the issue.What changes were proposed in this pull request?
This is only a documentation change
How was this patch tested?
Tested with the latest helm chart
Check all the applicable boxes
Docs link
Summary by Bito
This PR updates deployment documentation for flyte-core, adding specific Okta authentication configuration details. It provides guidance on setting allowedAudience parameters and modifying deployment URLs for proper token validation, addressing JWT audience mismatch issues when components are co-deployed.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1