Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the patches for Flux All-In-One installation #216

Open
kvaps opened this issue Apr 3, 2024 · 5 comments
Open

Implement the patches for Flux All-In-One installation #216

kvaps opened this issue Apr 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@kvaps
Copy link

kvaps commented Apr 3, 2024

Is your feature request related to a problem ?

There was a discussion on how to install FluxCD without CNI
fluxcd/flux2#3070

Right now there is no standard and convenient way for doing this.

Describe the solution you'd like.

Add additional option to values.yaml

# -- Implement the patches for Flux All-In-One installation as a single deployable unit (Kubernetes Pod).
# See https://github.com/fluxcd/flux2/discussions/3070
aio: false

Describe alternatives you've considered.

There are certain projects for solving this issue:

I'd like to have a common way to generate a ready manifests to apply.

Additional context.

I can prepare the PR for this feature, but let's first discuss if it is needed and how it should be implemented

cc @stefanprodan @maxpain
I would like to hear your opinion as well

@kvaps kvaps added the enhancement New feature or request label Apr 3, 2024
@kvaps kvaps changed the title Implement the patches for Flux All-In-One installationIssue Implement the patches for Flux All-In-One installation Apr 3, 2024
@maxpain
Copy link

maxpain commented Apr 3, 2024

Yes it's a really must have feature.

I deploy Cilium CNI using Flux on a lot of clusters.

@gecube
Copy link

gecube commented Oct 14, 2024

@maxpain won't FluxCD operator solve this issue? Anyway, I totally agree, that this option is a must. Particularly I want to highlight that it is not enough to put all fluxCD pods into host network, but also one needs to deal with DNS (as CoreDNS is not working w/o CNI)

@maulerjan
Copy link

This is something I'd really like Flux to support in a standardized way. My use-case is RKE2 with Cilium, I can't change Cilium config on the fly right now, as it has to be installed using RKE2's Helm chart installer before Flux. RKE2 has a built-in reconciliation, so it would create conflicts if I had Flux taken over the management of Cilium.

@gecube
Copy link

gecube commented Nov 25, 2024

@maulerjan disable cilium chart reconciliation on rke2 level or don't manage it by fluxcd.

@maulerjan
Copy link

maulerjan commented Dec 7, 2024

@maulerjan disable cilium chart reconciliation on rke2 level or don't manage it by fluxcd.

Didn't realize I can completely turn off RKE2 reconciliation for a Helm chart. Will give it a try, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants