Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The internal links inside installation/install-fluent-package were broken #565

Closed
livekn opened this issue Feb 6, 2025 · 3 comments
Closed

The internal links inside installation/install-fluent-package were broken #565

livekn opened this issue Feb 6, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@livekn
Copy link
Contributor

livekn commented Feb 6, 2025 •
edited
Loading

Describe the bug

The internal links were broken because it's inside "/installation/install-fluent-package", so should use "../../" instead of "../"

Image

Link to the problematic documentation

https://docs.fluentd.org/installation/install-fluent-package/install-by-rpm-fluent-package
https://docs.fluentd.org/installation/install-fluent-package/install-by-deb-fluent-package
https://docs.fluentd.org/installation/install-fluent-package/install-by-dmg-fluent-package
https://docs.fluentd.org/installation/install-fluent-package/install-by-msi-fluent-package

Expected explanation

The link should work

Additional context

No response
livekn added a commit to livekn/fluentd-docs-gitbook that referenced this issue Feb 6, 2025
@livekn
Fix broken link (fluent#565)
f72b5ed
@kenhys
Copy link
Contributor

kenhys commented Feb 6, 2025

Thanks!
If you afford to fix it, Pull request is wellcome.

livekn added a commit to livekn/fluentd-docs-gitbook that referenced this issue Feb 6, 2025
@livekn
Fix broken link (fluent#565)
f7caa66 
Signed-off-by: Toby Lam <[email protected]>
@livekn livekn mentioned this issue Feb 6, 2025
Merged
livekn added a commit to livekn/fluentd-docs-gitbook that referenced this issue Feb 6, 2025
@livekn
Fix broken links (fluent#565)
24708d3 
Signed-off-by: Toby Lam <[email protected]>
@livekn livekn changed the title "fluent-package v5 vs td-agent v4" link was broken The internal links inside installation/install-fluent-package were broken Feb 6, 2025
@livekn
Copy link
Contributor Author

livekn commented Feb 6, 2025

Update: all the internal links inside these pages were broken. I fix them all

daipom pushed a commit that referenced this issue Feb 7, 2025
@livekn
Fix broken links (#565) (#566)
29a6f6e 
Signed-off-by: Toby Lam <[email protected]>
@daipom
Copy link
Contributor

daipom commented Feb 7, 2025

Thanks so much!

@daipom daipom closed this as completed Feb 7, 2025
@daipom daipom added bug Something isn't working and removed waiting-for-triage labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Fluentd Kanban
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@livekn @kenhys @daipom