Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.0.3 not workig #17

Open
GigiPompieru opened this issue Jan 9, 2024 · 11 comments
Open

V0.0.3 not workig #17

GigiPompieru opened this issue Jan 9, 2024 · 11 comments

Comments

@GigiPompieru
Copy link

The new update broke the thermostat for me. Is this generic?

Logger: homeassistant.components.climate
Source: helpers/entity_platform.py:360
Integration: Climate ([documentation](https://www.home-assistant.io/integrations/climate), [issues](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+climate%22))
First occurred: 16:21:17 (1 occurrences)
Last logged: 16:21:17
Error while setting up salusfy platform for climate

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 360, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/salusfy/climate.py", line 78, in async_setup_platform
    await async_setup_reload_service(hass, DOMAIN, PLATFORMS)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
NameError: name 'async_setup_reload_service' is not defined

Originally posted by @GigiPompieru in #15 (comment)

@aver-ua
Copy link
Contributor

aver-ua commented Jan 9, 2024

i don't use last version, but seems to me that line 38 needs to be uncommented..

@Claudio1L
Copy link

same for me:
Logger: homeassistant.components.climate
Source: helpers/entity_platform.py:361
Integration: Climate (documentation, issues)
First occurred: 15:32:55 (1 occurrences)
Last logged: 15:32:55
Error while setting up salusfy platform for climate

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 361, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/salusfy/climate.py", line 78, in async_setup_platform
await async_setup_reload_service(hass, DOMAIN, PLATFORMS)
^^^^^^^^^^^^^^^^^^^^^^^^^^
NameError: name 'async_setup_reload_service' is not defined

@GigiPompieru
Copy link
Author

GigiPompieru commented Jan 9, 2024

i don't use last version, but seems to me that line 38 needs to be uncommented..

this fixed it.

What I have noticed is that it pulls the data slower than the old version.
I have 2 zones for my IT500, the second being an IT300, and the zone 2 gets the data 30 seconds before zone 1 after the restart.

Now I can see why:

This error originated from a custom integration.

Logger: custom_components.salusfy.climate
Source: custom_components/salusfy/climate.py:249
Integration: salusfy (documentation, issues)
First occurred: 16:51:31 (1 occurrences)
Last logged: 16:51:31

Error Geting the Session Token.
This error originated from a custom integration.

Logger: custom_components.salusfy.climate
Source: custom_components/salusfy/climate.py:281
Integration: salusfy (documentation, issues)
First occurred: 16:51:31 (1 occurrences)
Last logged: 16:51:31

Error Geting the data from Web. Please check the connection to salus-it500.com manually.

But after that it works, dunno what happens.

@aver-ua
Copy link
Contributor

aver-ua commented Jan 9, 2024

it's probably my fault..
I created a fork to fix the problem of deprecated constants #16 but before that I experimented with another pull request (not mine) #11 (YAML config restart) and forgot to remove commented out line 38 from this request. as a result of combining two pull requests, line 38 remained commented out, which is incorrect
in general, with request #11 I had problems when starting HA: errors in the log about an incorrect access token

@Claudio1L
Copy link

uncommenting line 38, it seems working, but I receive the following logs:

Logger: custom_components.salusfy.climate
Source: custom_components/salusfy/climate.py:249
Integration: salusfy (documentation, issues)
First occurred: 15:55:32 (1 occurrences)
Last logged: 15:55:32
Error Geting the Session Token.

Logger: homeassistant.util.async_
Source: util/async_.py:140
First occurred: 15:55:32 (2 occurrences)
Last logged: 15:55:32

Detected blocking call to putrequest inside the event loop by custom integration 'salusfy' at custom_components/salusfy/climate.py, line 242: self._session.post(URL_LOGIN, data=payload, headers=headers), please create a bug report at https://github.com/floringhimie/salusfy/issues
Detected blocking call to putrequest inside the event loop by custom integration 'salusfy' at custom_components/salusfy/climate.py, line 256: r = self._session.get(url = URL_GET_DATA, params = params), please create a bug report at https://github.com/floringhimie/salusfy/issues

Logger: custom_components.salusfy.climate
Source: custom_components/salusfy/climate.py:281
Integration: salusfy (documentation, issues)
First occurred: 15:55:32 (1 occurrences)
Last logged: 15:55:32
Error Geting the data from Web. Please check the connection to salus-it500.com manually.

Logger: homeassistant.helpers.service
Source: helpers/service.py:548
First occurred: 15:55:47 (1 occurrences)
Last logged: 15:55:47
Unable to find services.yaml for the salusfy integration

@GigiPompieru
Copy link
Author

The thermostat works after the initial errors. It sets the temperature in cloud and also reads any modifications you do in the salus app without any more errors.

Its very strange.

@Claudio1L
Copy link

I went back to 0.0.1 and manually applied #16 . Works fine and errors disappeared. @aver-ua #11 broke something.

@GigiPompieru
Copy link
Author

I went back to 0.0.1 and manually applied #16 . Works fine and errors disappeared. @aver-ua #11 broke something.

including the network errors?

@aver-ua
Copy link
Contributor

aver-ua commented Jan 11, 2024

I went back to 0.0.1 and manually applied #16 . Works fine and errors disappeared. @aver-ua #11 broke something.

yes, pull request #11 produces warnings and errors in HA log, but the component works
so, i use climate.py without #11

@Claudio1L
Copy link

Confirmed, seems ok without #11 Now the problem is that the update hacs is proposing includes #11 doesn't it?

@GigiPompieru
Copy link
Author

maybe create #17 with the final code that works without errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants