Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_input_shape in public bases #281

Open
BalzaniEdoardo opened this issue Dec 18, 2024 · 0 comments
Open

set_input_shape in public bases #281

BalzaniEdoardo opened this issue Dec 18, 2024 · 0 comments

Comments

@BalzaniEdoardo
Copy link
Collaborator

Copying mine and @billbrod comment to PR #276 regarding the set_input_shape of concrete classis in basis/basis.py.

I think we've already discussed this, but there's no way to have super().init() initialize both super classes?

My response:

This modification is quite complex and requires some precision, so we can leave it a future PR.
The method that in theory can work is the first one super().init() however, for this to work, for all the classes inheriting directly AtomicBasis and Basis, we need to invert the inheritance order.

This also doesn't work directly, because AtomicBasis is using some parameters that are defined at basis initialization.

I think this all can be smoothed out but requires precision and a dedicate PR. I'll add it to an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant