Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Chrome importer to emit schema-based markers #5308

Open
mstange opened this issue Jan 10, 2025 · 0 comments
Open

Change the Chrome importer to emit schema-based markers #5308

mstange opened this issue Jan 10, 2025 · 0 comments
Labels
profile data Issues related to the profile format, data structure, or profile upgraders

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

The Chrome importer currently creates markers whose data.type doesn't match a schema. Instead, we should have a schema and then set data.type to the name of the schema.

The data object also has other properties which need to be declared in a schema, for #5302.

In this example profile, most markers just have a category field. But some have a lot more data. You can find them by executing filteredMarkers.filter(m => m.data && Object.keys(m.data).length > 2) on the console.

I'm not sure what to do about that extra data. It could be stuffed in a field called chromeMarkerData with a new field format called freeform-object.

┆Issue is synchronized with this Jira Task

@canova canova added the profile data Issues related to the profile format, data structure, or profile upgraders label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile data Issues related to the profile format, data structure, or profile upgraders
Projects
None yet
Development

No branches or pull requests

2 participants