Make Network markers schema-based #5304
Labels
markers
Anything to do with marker data structures, marker chart, or the marker table
network panel
Related to the networking panel
Network markers currently don't have a schema.
For #5302, we'll need to create a schema which lists all useful fields. This will require an upgrader.
Furthermore, we have code when computing the derived markers, which treats Network markers in a special way and matches up markers based on
data.status
anddata.id
. If we have to upgrade these markers anyway, it may make sense to change them in such a way that we can remove this special handling.This issue is only about making this change to the processed format. The Gecko format can be changed in a separate step. Once the Gecko format is changed, changing the Gecko C++ code for network markers will hopefully not require changing the front-end anymore.
I suggest the following:
network-request-status
,network-request-priority
, andnetwork-request-http-version
, to preserve behavior in the tooltip which uses_getHumanReadableDataStatus
,_getHumanReadablePriority
and_getHumanReadableHttpVersion
.network-request-redirect-info
which expects values of type{ redirectType: string, isHttpToHttpsRedirect: bool }
, again to preserve behavior in the tooltip which creates entries such as "Redirection type:Permanent (HTTP to HTTPS)". Or, alternatively, just put the combined string into a regular string field, and remove the extra bool field.
network-request-mime-type
so that the tooltip can have the colored square in front of the mime type value.network-request-phase-timestamps
which is a JSON object containing all the timestamps of the various preflight/request/response phases.fetchStart
field which is unused.) Make sure that the marker name is just as unambiguous as thedata.id
field, so that the regular code for matching start/end markers based on the name works reliably.guessedMimeType
fields for markers from old profiles which didn't have amimeType
field.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: