Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizing out screenshots should keep CompositorScreenshot markers without the image #4162

Open
fqueze opened this issue Jul 29, 2022 · 1 comment

Comments

@fqueze
Copy link
Contributor

fqueze commented Jul 29, 2022

When we share a profile without screenshots it is typically because there was personal information on screen. It would be nice to still share the screenshot markers, without the images, so that when looking at the profile, it remains easily possible to see which window changed on screen, and what the size of the windows were.

Even better than removing the images might be to blur them entirely, or make them a solid color, that changes whenever 2 screenshots are different. Showing on the image which area of the screenshot differed would be even better.

┆Issue is synchronized with this Jira Task

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

If these markers were schema-based (#5303), and if fields could be declared as privacy-sensitive (#5301), then we could just make the data-url field in these markers privacy-sensitive, and no special handling in profile sanitization would be needed. This would keep the markers and remove the url field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants