Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message ID can be int, string, or null as per OpenRPC spec #48

Closed
wants to merge 4 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 8, 2021

Fixes: #28

handler.go Show resolved Hide resolved
@rvagg
Copy link
Member Author

rvagg commented Apr 9, 2021

Updated so all the map[uint64]s are map[interface{}] in websockets.go now, I'd left out chanHandlers. I think this is safe because it's per-client so it's therefore up to the client to get the IDs sorted out properly. A test for this via websockets might be nice but I suspect that'd be an enormous amount of work just to test strings.

@rvagg
Copy link
Member Author

rvagg commented Jun 24, 2021

@magik6k any chance of getting some eyes on this? I know it's not a trivial change but it'd be nice to be able to support OpenRPC properly.

@rjan90
Copy link

rjan90 commented Jan 7, 2025

Hey! 👋

As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR?

1. Close it: If it's no longer needed.
2. Mark as Draft: If it needs more work, and add the next steps.
3. Ready for Review: If it's good to go, let me know, and I'll assign a reviewer.

If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know.

Thanks for your help in keeping things organized, and I appreciate your contributions!

@rvagg
Copy link
Member Author

rvagg commented Jan 7, 2025

oh .. wow, this is mine? why did I even do this?

looks like the current code has an approximation of this, good enough and I don't think there have been complaints of late

@rvagg rvagg closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse non-numerical ID
3 participants