Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Add Traditional Chinese #245

Open
Jenny-HT opened this issue Dec 24, 2019 · 11 comments
Open

Add Traditional Chinese #245

Jenny-HT opened this issue Dec 24, 2019 · 11 comments

Comments

@Jenny-HT
Copy link
Contributor

Traditional Chinese is widely used in Taiwan, Hong Kong and Macau. To support Traditional Chinese, please adopt the IETF BCP 47 language tags.

@Jenny-HT
Copy link
Contributor Author

Jenny-HT commented Feb 10, 2020

I created a pull request #252 for adding the language of Chinese (Hong Kong).

@jidanni
Copy link

jidanni commented Dec 20, 2020

@Jenny-HT
Copy link
Contributor Author

See also https://fetlife.com/groups/11573/posts/17467543

Thank you for your input. I think we can collaborate on most of the contents. However, some of them will be different in Hong Kong and Taiwan, which I want to respect the readers from both places.

@jidanni
Copy link

jidanni commented Dec 22, 2020

@kmxz
Copy link
Contributor

kmxz commented Jan 11, 2021

Hi! I'm the main author of the Simplified-Chinese translation in this repository.

Just want to mention that it's possible to convert zh-CN, zh-HK and zh-TW variants to each other automatically. The translation tables used by Chinese Wikipedia seem to handle the translations pretty well (see https://zh.wikipedia.org/wiki/Wikipedia:CST); alternatively, we can use OpenCC for it. Using the convertion tools can reduce the work a lot.

I can generate those variants automatically and put them in a separate PR, if needed.

@jidanni
Copy link

jidanni commented Jan 11, 2021

As 'the mainland vocabulary is better than no vocabulary', I would say go right ahead.

@Jenny-HT
Copy link
Contributor Author

I understand that there is a requirement of the translated items of an added language from another merge request. I will take reference of the Simplified Chinese and add as many translation as I can. I will also try not to upset my Hong Kong fellows as well. Thank you for your input. :)

@Jenny-HT
Copy link
Contributor Author

I can generate those variants automatically and put them in a separate PR, if needed.

It will be cool! :)

If you don't mind, can you open a PR in my forked repo instead?

@kmxz
Copy link
Contributor

kmxz commented Jan 12, 2021

I can generate those variants automatically and put them in a separate PR, if needed.

It will be cool! :)

If you don't mind, can you open a PR in my forked repo instead?

I've done the conversion, and the changes can be previewed at master...kmxz:master.

I would personally prefer to create a PR directly to the original repo, just for simplicity (as I'm putting the a few changes together, including adding zh-HK and zh-TW translations, renaming zh to zh-CN, reformatting, and catching up missing translations). You can always update the translations later.

But I'm definitely open to merging the changes into your forked repo first, if we have a good reason to do so.

@Jenny-HT
Copy link
Contributor Author

In that case, I will check your repo asap and make any changes on your repo if I have any concern. In case you don't hear me back or you find yourself waiting too long, just feel free to proceed. :)

@Jenny-HT
Copy link
Contributor Author

I started reviewing the changes from @kmxz today. I think it will take some time for me to complete it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants