Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_source method RA/DEC vs. ra/dec #615

Open
tibaldo opened this issue Dec 3, 2024 · 0 comments
Open

add_source method RA/DEC vs. ra/dec #615

tibaldo opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels

Comments

@tibaldo
Copy link
Contributor

tibaldo commented Dec 3, 2024

While debugging an analysis script that was producing nonsensical results I found out that the add_source method with a dictionary as input only accepts keys for the sky direction of the source in lower case (ra, dec). If you try to pass the keys in upper case (RA, DEC, which is the convention used in the xml files for the femitools) add_source ignores the upper-case keys and sets the source position at a default value.
I think that this behavior is not desirable. add_source should either 1) accept both ra/dec and RA/DEC or 2) throw an error if key expected parameter values (like the source position) are not found.
What would be the best solution?

@ndilalla ndilalla added the bug label Dec 19, 2024
@ndilalla ndilalla self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants