You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While debugging an analysis script that was producing nonsensical results I found out that the add_source method with a dictionary as input only accepts keys for the sky direction of the source in lower case (ra, dec). If you try to pass the keys in upper case (RA, DEC, which is the convention used in the xml files for the femitools) add_source ignores the upper-case keys and sets the source position at a default value.
I think that this behavior is not desirable. add_source should either 1) accept both ra/dec and RA/DEC or 2) throw an error if key expected parameter values (like the source position) are not found.
What would be the best solution?
The text was updated successfully, but these errors were encountered:
While debugging an analysis script that was producing nonsensical results I found out that the add_source method with a dictionary as input only accepts keys for the sky direction of the source in lower case (ra, dec). If you try to pass the keys in upper case (RA, DEC, which is the convention used in the xml files for the femitools) add_source ignores the upper-case keys and sets the source position at a default value.
I think that this behavior is not desirable. add_source should either 1) accept both ra/dec and RA/DEC or 2) throw an error if key expected parameter values (like the source position) are not found.
What would be the best solution?
The text was updated successfully, but these errors were encountered: