From 4e89027f4fef43bd031202aa480f5500e24f3a45 Mon Sep 17 00:00:00 2001 From: Felipe Noronha Date: Sun, 22 Sep 2024 00:10:39 -0300 Subject: [PATCH 1/2] remove gc calls Related to #42 and #173 --- src/read.jl | 3 --- src/write.jl | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/read.jl b/src/read.jl index 9f3e304..08c8b3b 100644 --- a/src/read.jl +++ b/src/read.jl @@ -146,9 +146,6 @@ function openxlsx(f::F, source::Union{AbstractString, IO}; else close(xf) end - - # fix libuv issue on windows (#42) and other systems (#173) - GC.gc() end end diff --git a/src/write.jl b/src/write.jl index f400a32..e3c1253 100644 --- a/src/write.jl +++ b/src/write.jl @@ -83,8 +83,6 @@ function writexlsx(output_source::Union{AbstractString, IO}, xf::XLSXFile; overw print(xlsx, generate_sst_xml_string(get_sst(xf))) end end - # fix libuv issue on windows (#42) - @static Sys.iswindows() ? GC.gc() : nothing nothing end From 9f86c8d8196ef667419b839c70b7a44725f2bc67 Mon Sep 17 00:00:00 2001 From: Felipe Noronha Date: Sun, 22 Sep 2024 00:18:51 -0300 Subject: [PATCH 2/2] revert write gc call on windows --- src/write.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/write.jl b/src/write.jl index e3c1253..f400a32 100644 --- a/src/write.jl +++ b/src/write.jl @@ -83,6 +83,8 @@ function writexlsx(output_source::Union{AbstractString, IO}, xf::XLSXFile; overw print(xlsx, generate_sst_xml_string(get_sst(xf))) end end + # fix libuv issue on windows (#42) + @static Sys.iswindows() ? GC.gc() : nothing nothing end