From 39ffc153a975618d74b22eb629abe6e361607225 Mon Sep 17 00:00:00 2001 From: TimG1964 <157401228+TimG1964@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:21:59 +0100 Subject: [PATCH] Remove the gc call in write.jl (#271) This gc call was added in Windows only, apparently in response to issue #42. The consequence was that `writexlsx()` was much slower, with 97% of time spent on gc (in my use case). Deleting this line speeds up `writexlsx()` forty-fold and XLSX still passes all tests. Not sure what, if any, downsides there might be in other use cases. --- src/write.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/write.jl b/src/write.jl index f400a32..e3c1253 100644 --- a/src/write.jl +++ b/src/write.jl @@ -83,8 +83,6 @@ function writexlsx(output_source::Union{AbstractString, IO}, xf::XLSXFile; overw print(xlsx, generate_sst_xml_string(get_sst(xf))) end end - # fix libuv issue on windows (#42) - @static Sys.iswindows() ? GC.gc() : nothing nothing end