You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'll have to verify this, but I believe that as things stand, the web UI will allow you to file waivers for required tests that are queued/running, but the greenwave gating status calculation does not take such waivers into account. Obviously that's inconsistent.
Personally I think it's correct that we don't allow queued/running tests to be waived. If we go with that, then the Bodhi web UI should not offer to file waivers for queued/running tests, only failed and possibly missing ones (I'll have to check if greenwave 'accepts' waivers for missing tests).
Also, if a waiver for a queued/running test somehow exists (e.g. someone creates it directly in waiverdb), it shouldn't be considered as 'applying', i.e. we shouldn't show the thumbs-up for it on the Automated Results tab. This overlaps somewhat with #5397 .
The text was updated successfully, but these errors were encountered:
A post from @rwmjones on devel highlighted some issues with waivers and queued/running tests:
https://lists.fedoraproject.org/archives/list/[email protected]/thread/CAGORC7P56D66CTYIQ4PT2SO4GJHGEB2/
I'll have to verify this, but I believe that as things stand, the web UI will allow you to file waivers for required tests that are queued/running, but the greenwave gating status calculation does not take such waivers into account. Obviously that's inconsistent.
Personally I think it's correct that we don't allow queued/running tests to be waived. If we go with that, then the Bodhi web UI should not offer to file waivers for queued/running tests, only failed and possibly missing ones (I'll have to check if greenwave 'accepts' waivers for missing tests).
Also, if a waiver for a queued/running test somehow exists (e.g. someone creates it directly in waiverdb), it shouldn't be considered as 'applying', i.e. we shouldn't show the thumbs-up for it on the Automated Results tab. This overlaps somewhat with #5397 .
The text was updated successfully, but these errors were encountered: