Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutrals BC wrong at the anode #4

Open
MartinGuillonLPP opened this issue Aug 23, 2024 · 1 comment
Open

Neutrals BC wrong at the anode #4

MartinGuillonLPP opened this issue Aug 23, 2024 · 1 comment

Comments

@MartinGuillonLPP
Copy link
Collaborator

For all branches based on main

In FLHET_compiled.py,
in

362 def SetInlet(...):
...
368 U_ghost[0] = (mdot - M * P_In[1] * P_In[2] / VG) / (A0 * VG)

is wrong to me because dimensionally not right. It should be:

368 U_ghost[0] = (mdot - M * P_In[1] * P_In[2] * A0) / (A0 * VG)

I don't think it is of great impact because the usual values we were using of $1/{VG}=0.005$ s/m and A0 $\approx 0.0044$ $m^2$ are close.

I already pushed a correction on main. I publish this issue for the devs of other branches who may be impacted.

@federicopetronio
Copy link
Owner

Correct, well noticed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants