From 6c50c0b5630dc5e81a2a79373289ba3de3fb9d46 Mon Sep 17 00:00:00 2001 From: Frederic Charette Date: Mon, 24 Oct 2022 16:33:29 -0400 Subject: [PATCH] Updated Github action (#125) * added cache step to github action, updated task versions * string-safe workflow name * bad id name in npm cache * use core node setup * removed cache flag * updated coalesced values for node 18 - it's too fast --- .github/workflows/pr-validation.yml | 10 +++++----- tests/profiling/settings.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml index fc23967..d89cd1c 100644 --- a/.github/workflows/pr-validation.yml +++ b/.github/workflows/pr-validation.yml @@ -1,4 +1,4 @@ -name: pr-validation +name: "pr-validation" on: pull_request: @@ -12,17 +12,17 @@ jobs: strategy: matrix: - node-version: [14.x, 16.x] + node-version: [14.x, 16.x, 18.x] steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - name: Start Redis uses: supercharge/redis-github-action@1.4.0 - - name: npm install, build, and test + - name: npm install, build, test and benchmark run: | npm install npm run lint diff --git a/tests/profiling/settings.js b/tests/profiling/settings.js index 0aab203..6477840 100644 --- a/tests/profiling/settings.js +++ b/tests/profiling/settings.js @@ -12,7 +12,7 @@ module.exports = { }, assert: { completed: [300000, 300000], - coalescedHit: [8000, 50000], + coalescedHit: [7000, 50000], cacheHits: [35000, 50000], timeouts: [0, 0], batches: [4800, 5300],