Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Production Filing Destination (downstream) #1301

Open
exalate-issue-sync bot opened this issue Jan 24, 2025 · 4 comments
Open

Implement Production Filing Destination (downstream) #1301

exalate-issue-sync bot opened this issue Jan 24, 2025 · 4 comments
Assignees

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Jan 24, 2025

Task: Update filings destinations (downstream) for our Production environment. Update the EFO api uri and the API key in the creds service

Given the PRODUCTION environment only,

When sending data to EFO services for *.fec file submission and *.fec print preview,

Then the data destinations will be as follows:

QA Notes

Screenshot of updated EFO_FILING_API in prod manifest.

DEV Notes

  • This amounts to updating {{EFO_FILING_API}} in manifest-prod.yml to from {{https://efoservices.stage.efo.fec.gov}} to {{https://efoservices.efo.fec.gov}} as well as

  • updating {{EFO_FILING_API_KEY}} to be our prod EFO api key
    🔒 [https://docs.google.com/spreadsheets/d/1lIOn8kIwpCOMh6JCMZaiGH5v2h7Dzw-ac-5jpOSC6Jc/edit?gid=0#gid=0|https://docs.google.com/spreadsheets/d/1lIOn8kIwpCOMh6JCMZaiGH5v2h7Dzw-ac-5jpOSC6Jc/edit?gid=0#gid=0] 🔒

  • Contacting EFO will be necessary to receive API key.

  • Record rate limits or other limitations in this ticket

Design

null

See full ticket and images here: FECFILE-1975

Pull Request: #1354

Copy link
Author

akhorsand commented: [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] can you take a look and make any adjustments if needed, then we can move to refinement queue? Thanks!

@exalate-issue-sync exalate-issue-sync bot changed the title Implement Production Committee Data Source (downstream) Implement Production Filing Destination (downstream) Feb 6, 2025
Copy link
Author

Laura Beaufort commented: Not going to screenshot the API key - can verify with

{noformat}cf target -s prod

cf env fecfile-web-api | grep "EFO_FILING_API_KEY"{noformat}

Copy link
Author

Laura Beaufort commented: Confirmed there aren’t limits or restrictions on the key.

Copy link
Author

Todd Lees commented: [https://github.com/fecgov/fecfile-web-api/blob/ca233bd832fa3e166e55aa69f3fb44c772441801/manifests/manifest-prod.yml#L22|https://github.com/fecgov/fecfile-web-api/blob/ca233bd832fa3e166e55aa69f3fb44c772441801/manifests/manifest-prod.yml#L22|smart-link]

!image-20250227-203820.png|width=794,height=620,alt="image-20250227-203820.png"!

Production EFO api url is now in manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants