Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance for TSX? #4

Open
pauleveritt opened this issue May 2, 2018 · 3 comments
Open

Any chance for TSX? #4

pauleveritt opened this issue May 2, 2018 · 3 comments

Comments

@pauleveritt
Copy link

I'm enjoying using this in my Sphinx documentation. I do TypeScript with React and many things seem to work, but this for example fails:

class BlogPost extends React.Component<ICounterProps, ICounterState> {
}

...whereas this works:

class BlogPost extends React.Component<{}, {}> {
}

I can make a PR with a failing test if it helps.

@fcurella
Copy link
Owner

fcurella commented May 3, 2018

Thank you!

Supporting tsx would be nice, but I don't know how easy would it be to implement. Feel free to submit a PR with the failing test, but I'm not sure I'll have much time to dedicate to implementing the feature.

@martinzuern martinzuern mentioned this issue Feb 7, 2020
2 tasks
@csabasulyok
Copy link

@fcurella Thanks for the lexer. Would also love to see TSX support. Any chance of checking out @martinzuern 's Pull Request? #8

Cheers!

@fcurella
Copy link
Owner

Sorry I've let this slip through. The PR looks good. The only thing missing is some test cases for TSX. I'll see if @martinzuern is still available.

@cad0p cad0p mentioned this issue Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants