Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column field name exposure #30

Open
jvmlet opened this issue Apr 2, 2019 · 7 comments
Open

Column field name exposure #30

jvmlet opened this issue Apr 2, 2019 · 7 comments

Comments

@jvmlet
Copy link

jvmlet commented Apr 2, 2019

Hello
Would you please expose col{index}_fieldName (for each column) context variables when your process the handlebar template ? This will allow to create drill down link to another dashboard with filter definition. Currently, only the field value can be captured, not the field name.
Thanks

@fbaligand
Copy link
Owner

Hello,

Well, the field name is a static information.
I mean that the field name is a static element for each bucket/metric aggregation in your visualization.
So I don't understand why you need it as a dynamic information in your computed columns.
Can you explain me a concrete need?

@jvmlet
Copy link
Author

jvmlet commented Apr 3, 2019

Suppose I've formatted 2 custom columns as URL to another dashboard, each one adds the filter definition by it's own field name and value to the URL of this dashboard. The URL template is the same, the only difference is the fieldName and value. Being able to template the URL using {{col0_fieldName}} and {{value}} results with single pattern, otherwise I need to copy-paste the URL and statically put the fieldName in for each of them.

@fbaligand
Copy link
Owner

Well, so if I understand well, it will just allow you to not have to adapt template value for 2 computed columns? Right?
Honestly, this seems low value enhancement.

But if it's important for you, don't hesitate to make a pull request to add this feature!

@jvmlet
Copy link
Author

jvmlet commented Apr 7, 2019

Well, it might be not 2 but N columns. IMHO, this should exist just for API completeness.

Will try to add this if I have time.
Thanks again for the awesome plugin.

@fbaligand
Copy link
Owner

If you make a PR, I will be happy to merge it!

Happy to see you enjoy the plugin!

@umarfachreza
Copy link

hi fbaligand, I had a same issue, if i want to change order columns but its a date histogram columns, we cant create computed columns that just reference the col1 cause we didnt know what date will the column label, can we reference col label too so columns name will dynamic ?

image

want to be this

image

@fbaligand
Copy link
Owner

Hi @umarfachreza,
This issue feature is really different from what you talk about.
We can yak about it in the other issue where you tell the same need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants