feat: Add OpenTelemetry setup function #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
from
7eb6574 to
181e5cf
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
+ Coverage 67.24% 77.80% +10.55%
===========================================
Files 5 8 +3
Lines 232 491 +259
===========================================
+ Hits 156 382 +226
- Misses 76 109 +33
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
2cc3d5e to
9f45534
Compare
|
We should probably guard this behind cargo feature |
sirewix
reviewed
Jan 8, 2025
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
2 times, most recently
from
3bb5329 to
4c1d1df
Compare
sirewix
reviewed
Jan 8, 2025
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
7e9a05f to
ac11152
Compare
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
2 times, most recently
from
06f3601 to
5ad809d
Compare
sirewix
reviewed
Jan 9, 2025
sirewix
reviewed
Jan 9, 2025
|
What's the difference between stdout layer and logs layer? |
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
from
5ad809d to
e355992
Compare
the stdout layer only logs to the stdout and the logs layer only exports the logs to and otel collector |
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
ea95e16 to
85d0e49
Compare
mzaniolo
changed the title
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
f8994cd to
c7bf78c
Compare
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
9f8bb11 to
31bd81d
Compare
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
2 times, most recently
from
c899ea2 to
4dce311
Compare
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
3 times, most recently
from
ea2004a to
cc1cd81
Compare
sirewix
reviewed
Jan 13, 2025
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
4 times, most recently
from
5f81383 to
f21c2ab
Compare
sirewix
reviewed
Jan 15, 2025
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
from
f21c2ab to
338fe33
Compare
sirewix
reviewed
Jan 16, 2025
sirewix
previously approved these changes
Jan 16, 2025
mzaniolo
force-pushed
the
mzaniolo/telemetry
branch
from
338fe33 to
b922cd1
Compare
sirewix
approved these changes
Jan 17, 2025
|
This code got to big and was moved to a separated repo. This PR was replaced by https://github.com/famedly/rust-telemetry/pull/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to setup the Opentelemetry exporting for logs, traces and metrics.
This function will setup everything, all that will be left to do on the services is to setup the propagation layer (example for axum) and configure the
#[instrument]macro on the functions.For metric I setup to use the traces for metrics using the crate tracing-opentelemetry. Other options are the opentelemetry sdk itself, and the metrics.
The metrics doesn't seem to have an opentelemtry exporter but it does have an prometheus exporter. If we choose to use an collector that supports both, otel and prometheus endpoints, like grafana alloy, the metrics crate can also be an option