Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data refetched when going between location and edit review form #654

Open
wbazant opened this issue Dec 28, 2024 · 0 comments
Open

Data refetched when going between location and edit review form #654

wbazant opened this issue Dec 28, 2024 · 0 comments
Labels
bug Unexpected problems or unintended behavior mobile Specific to mobile layout

Comments

@wbazant
Copy link
Collaborator

wbazant commented Dec 28, 2024

  1. When we open an 'Edit review' form for a user editing their review, and press back, we expect to come back to the fully open drawer and the review tab: like with Add Review or Edit Location forms, which work correctly. Instead, we go back to the map, and open the drawer.

My guess for the cause is that the location state in redux gets reset when going to the review form, but it shouldn't.

  1. Going from the location page to the 'Edit review' form briefly shows a white screen, which takes longer if the review contains a photo. This is not necessary since we already have the review data fetched - it came with the location - so we could be opening the form straight away.
@wbazant wbazant added bug Unexpected problems or unintended behavior mobile Specific to mobile layout labels Dec 28, 2024
@wbazant wbazant changed the title Going back from 'Edit review' form comes back to the half open drawer Data refetched when going between location and review Dec 28, 2024
@wbazant wbazant changed the title Data refetched when going between location and review Data refetched when going between location and edit review form Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior mobile Specific to mobile layout
Projects
None yet
Development

No branches or pull requests

1 participant