Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing the harvest page: filter by active/inactive #633

Open
wbazant opened this issue Dec 7, 2024 · 2 comments
Open

Sharing the harvest page: filter by active/inactive #633

wbazant opened this issue Dec 7, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@wbazant
Copy link
Collaborator

wbazant commented Dec 7, 2024

There's a small inconsistency between what we say and show.

The verbiage says, e.g. in English:

Those with crossed-out names are believed to be inactive.

but actually, we fade out the links:

Screenshot from 2024-12-07 09-31-24

We'll want to update the translations later, but the table could make better use of information about being active or inactive - see Ethan's comment below.

@wbazant wbazant added good first issue Good for newcomers translation labels Dec 7, 2024
@ezwelty
Copy link
Collaborator

ezwelty commented Dec 7, 2024 via email

@ezwelty
Copy link
Collaborator

ezwelty commented Dec 10, 2024

@wbazant Thinking about this more...

The data from which this table is generated has way more information than we are currently displaying or making actionable to the user (https://docs.google.com/spreadsheets/d/1GSB07pn7RMbZbFwv85CextwGzUTTGE2ZJZxn0XxvoEg/edit?gid=15), namely organization types, whether they donate food or not, and whether they are active or not. So probably the better long-term fix is to add these additional attributes (in our case: active / inactive), offer a way to filter by these, and find a way to display the data on narrow screens (multi-line rows?).

@wbazant wbazant changed the title Verbiage vs. UI in /sharing page Sharing the harvest page: filter by active/inactive Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants