Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form edits are lost when coming back from settings #546

Open
wbazant opened this issue Oct 27, 2024 · 2 comments
Open

Form edits are lost when coming back from settings #546

wbazant opened this issue Oct 27, 2024 · 2 comments
Labels
bug Unexpected problems or unintended behavior

Comments

@wbazant
Copy link
Collaborator

wbazant commented Oct 27, 2024

Follow-up from #545. I claim this is a bug but a small one

@wbazant wbazant added the bug Unexpected problems or unintended behavior label Oct 27, 2024
@wbazant
Copy link
Collaborator Author

wbazant commented Dec 15, 2024

See also: #604 about going back from add location

@wbazant wbazant self-assigned this Dec 15, 2024
@wbazant wbazant changed the title Save form edits when going edit location / review -> settings, bring them back on back Form edits are lost when coming back from settings Dec 31, 2024
@wbazant
Copy link
Collaborator Author

wbazant commented Dec 31, 2024

Instead of saving the intermediate state of the form, we can also not go back to forms but to the location page or to the map instead - let opening settings dismiss edits.

I've learned it's quite laborious to keep the intermediate state of the form for just the right context, and the feature of 'you can go to settings and change map type, and go back to editing' is not something anyone asked for - I just half-introduced it when thinking about the 'back from settings' destinations.

@wbazant wbazant removed their assignment Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant