From 5702b75d6d40f42d4e185abd49624aa1252422f8 Mon Sep 17 00:00:00 2001
From: AkashRajpurohit <me@akashrajpurohit.com>
Date: Mon, 6 Jan 2025 19:50:56 +0530
Subject: [PATCH] fix: add permission check for requests count badge; extract
 into a component

---
 src/components/Layout/Sidebar/index.tsx | 57 +++++++++++++++++--------
 1 file changed, 39 insertions(+), 18 deletions(-)

diff --git a/src/components/Layout/Sidebar/index.tsx b/src/components/Layout/Sidebar/index.tsx
index 6af3c2511..7ddffb338 100644
--- a/src/components/Layout/Sidebar/index.tsx
+++ b/src/components/Layout/Sidebar/index.tsx
@@ -117,6 +117,33 @@ const SidebarLinks: SidebarLinkProps[] = [
   },
 ];
 
+const PendingRequestsBadge = ({
+  requests,
+  hasPermission,
+}: {
+  requests: RequestCountResponse | undefined;
+  hasPermission: (
+    permission: Permission | Permission[],
+    options?: { type: 'and' | 'or' }
+  ) => boolean;
+}) => {
+  if (
+    !hasPermission([Permission.MANAGE_REQUESTS, Permission.ADMIN], {
+      type: 'or',
+    }) ||
+    !requests ||
+    requests.pending === 0
+  ) {
+    return null;
+  }
+
+  return (
+    <span className="ml-3">
+      <Badge badgeType="default">{requests.pending}</Badge>
+    </span>
+  );
+};
+
 const Sidebar = ({ open, setClosed }: SidebarProps) => {
   const navRef = useRef<HTMLDivElement>(null);
   const router = useRouter();
@@ -210,15 +237,12 @@ const Sidebar = ({ open, setClosed }: SidebarProps) => {
                             {intl.formatMessage(
                               menuMessages[sidebarLink.messagesKey]
                             )}
-                            {sidebarLink.messagesKey === 'requests' &&
-                              requests &&
-                              requests.pending > 0 && (
-                                <span className="ml-3">
-                                  <Badge badgeType="default">
-                                    {requests.pending}
-                                  </Badge>
-                                </span>
-                              )}
+                            {sidebarLink.messagesKey === 'requests' && (
+                              <PendingRequestsBadge
+                                requests={requests}
+                                hasPermission={hasPermission}
+                              />
+                            )}
                           </Link>
                         );
                       })}
@@ -280,15 +304,12 @@ const Sidebar = ({ open, setClosed }: SidebarProps) => {
                       {intl.formatMessage(
                         menuMessages[sidebarLink.messagesKey]
                       )}
-                      {sidebarLink.messagesKey === 'requests' &&
-                        requests &&
-                        requests.pending > 0 && (
-                          <span className="ml-3">
-                            <Badge badgeType="default">
-                              {requests.pending}
-                            </Badge>
-                          </span>
-                        )}
+                      {sidebarLink.messagesKey === 'requests' && (
+                        <PendingRequestsBadge
+                          requests={requests}
+                          hasPermission={hasPermission}
+                        />
+                      )}
                     </Link>
                   );
                 })}