From 5e7e5a0758f49cf2f81efc50795783879040a4ce Mon Sep 17 00:00:00 2001 From: develop084 Date: Mon, 18 Dec 2023 18:35:00 +0000 Subject: [PATCH 1/2] bug:changed the type for overridesfortoken --- packages/stylex/src/StyleXTypes.d.ts | 2 +- packages/stylex/src/StyleXTypes.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/stylex/src/StyleXTypes.d.ts b/packages/stylex/src/StyleXTypes.d.ts index b272b56c7..678571075 100644 --- a/packages/stylex/src/StyleXTypes.d.ts +++ b/packages/stylex/src/StyleXTypes.d.ts @@ -200,7 +200,7 @@ export type Theme< type OverridesForTokenType = { [Key in keyof Config]: | Config[Key] - | { default: Config[Key]; [atRule: AtRuleStr]: Config[Key] }; + | { default: Config[Key]; [atRule: string]: Config[Key] }; }; export type StyleX$CreateTheme = < diff --git a/packages/stylex/src/StyleXTypes.js b/packages/stylex/src/StyleXTypes.js index 218b96274..04736f7d2 100644 --- a/packages/stylex/src/StyleXTypes.js +++ b/packages/stylex/src/StyleXTypes.js @@ -42,6 +42,7 @@ type CSSPropertiesWithExtras = $ReadOnly<{ '::-webkit-search-cancel-button'?: CSSProperties, '::-webkit-search-results-button'?: CSSProperties, '::-webkit-search-results-decoration'?: CSSProperties, + }>; export type NestedCSSPropTypes = $ReadOnly<{ From b75359d904217c7ada3fa1048cda76d7b0943814 Mon Sep 17 00:00:00 2001 From: develop084 Date: Mon, 18 Dec 2023 20:26:51 +0000 Subject: [PATCH 2/2] bug: updated js file --- packages/stylex/src/StyleXTypes.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/stylex/src/StyleXTypes.js b/packages/stylex/src/StyleXTypes.js index 04736f7d2..8ff30fce6 100644 --- a/packages/stylex/src/StyleXTypes.js +++ b/packages/stylex/src/StyleXTypes.js @@ -177,12 +177,13 @@ export type Theme< [string]: StyleXClassNameFor>, }>; -export type OverridesForTokenType = { +export type OverridesForTokenType = { [Key in keyof Config]: | Config[Key] - | { +default: Config[Key], +[string]: Config[Key] }, + | { default: Config[Key]; [property: string]: Config[Key] }; }; + export type StyleX$CreateTheme = < BaseTokens: VarGroup<{ +[string]: mixed }>, ID: string = string,