Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbols in prelude files (passed in via --prelude) don't autocomplete in lsp mode #114

Open
chancila opened this issue Mar 8, 2024 · 1 comment

Comments

@chancila
Copy link

chancila commented Mar 8, 2024

Is it expected that symbols in the prelude autocomplete when using the vscode extension + the plain starlark binary in LSP mode?

I've tweaked the the VS code LSP args to pass --prelude in, and doing cargo run -- some_test_file.star --prelude prelude.star causes a successful evaluation, however the LSP server does not seem to have any symbols in the prelude in completion requests in VS code

@ndmitchell
Copy link
Contributor

I don't think anyone considered it too carefully. Generally most people will need to build their own LSP to deal with their own Rust builtins. I think we'd probably accept a patch to make that work, but think of the unmodified LSP as mostly for demo purposes. Generally you build a specific one for your project and ship that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants