Animated: Add Missing super.__attach() Calls
#48513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67884975 |
Summary: While refactoring `Animated`, I noticed that many subclasses of `AnimatedNode` override `__attach` without invoking the superclass method, even though we do this for `__detach`. In order to minimize surprise (e.g. if someone were to add logic into `AnimatedNode.prototype.__attach`), this diff updates all method overrides to invoke `super.__attach()`. Changelog: [Internal] Reviewed By: javache Differential Revision: D67884975
yungsters
force-pushed
the
export-D67884975
branch
from
f925673 to
2865a04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67884975 |
|
This pull request has been merged in d3c5f6d. |
|
This pull request was successfully merged by @yungsters in d3c5f6d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While refactoring
Animated, I noticed that many subclasses ofAnimatedNodeoverride__attachwithout invoking the superclass method, even though we do this for__detach.In order to minimize surprise (e.g. if someone were to add logic into
AnimatedNode.prototype.__attach), this diff updates all method overrides to invokesuper.__attach().Changelog:
[Internal]
Differential Revision: D67884975