2024-09-02

Add class to source map support for instrumentation test apk

Summary: We are using coverage data for code coverage based test selection and we need to coverate data for test itself to make sure that we will select it in only test was changed.

Reviewed By: IanChilds

Differential Revision: D62024851

fbshipit-source-id: 81ecb75f1135b4f96f3d85f6624051c93f496786

2024-08-15

Fixup for linkage on doctests

Summary:
We need to pass deps as immediate dependencies alongside the rlib when constructing linker args, so that we actually get the required `-lfoo` etc args on the link line.

Without this, we get undefined symbols when building doctests with `advanced_unstable_linking`.

Reviewed By: JakobDegen

Differential Revision: D61298029

fbshipit-source-id: 65594651e3f4716771b3e8d91bfd482fbd430222

2024-08-01

rust-project: Don't use incremental actions for clippy

Summary: D59887013 seems to have broken clippy warnings, although it's unclear to me why. Revert that change so we continue to offer clippy warnings in the IDE.

Reviewed By: Imxset21

Differential Revision: D60558322

fbshipit-source-id: 954b4f1093452bbbd474a4031e4b790bcf77355d

2024-07-15

configs: Fallible file existence check

Summary: This operation is not actually infallible

Reviewed By: stepancheg

Differential Revision: D59664959

fbshipit-source-id: 11916f71b50919910bd9ca5491372804d1c41b10

2024-07-01

Avoid an unnecessary collect into a Vec

Summary: Simplify and avoid additional memory.

Reviewed By: perehonchuk

Differential Revision: D59218144

fbshipit-source-id: 643cf4ecc5217775401ec20aac8ea416b4625502

2024-06-15

Move mod buildfiles out of mod legacy_configs

Summary: `buildfiles` is a user of buckconfigs, not part of the implementation.

Reviewed By: cjhopman

Differential Revision: D58610698

fbshipit-source-id: f8252eff384903d09aeba0389eca5d529d5c39f3

2024-06-01

rust-project: Warn on unowned files

Summary: Log a warning message if we can't determine the owner of a file passed to `develop`, but _is_ in fbsource (i.e., we already log if buck can't determine an owner because it's outside of the repo, but now we also log if it's in the repo but unowned).

Reviewed By: Wilfred

Differential Revision: D57947948

fbshipit-source-id: 1fd06b41341503b58e39748e994cd14f18880a6c

2024-05-15

Update the build modes to use for debug/release in Xcode

Reviewed By: blackm00n

Differential Revision: D57332237

fbshipit-source-id: 7293ff5e896130eb0cfbf6abfcad810d2d20879a

2024-05-01

Prefer pub(crate) for visibility

Summary:
`pub(crate)` generally gives better 'unused definition' warnings from rustc, because it knows the definition isn't used elsewhere.

Use `pub(crate)` wherever we can, and fix definitions that didn't need to be `pub` or `pub(crate)`.

Reviewed By: samkevich

Differential Revision: D56778389

fbshipit-source-id: b73364f96e9601e94a1196b25f78e92968a3edb0

2024-04-15

Simplify select tests

Summary: Pass resolved select keys to `select_the_most_specific` instead of passing `ResolvedConfigurationSettings` which contains incompatible keys too.

Reviewed By: JakobDegen

Differential Revision: D56121980

fbshipit-source-id: 1d278c1a746a6fac92303f20a2cbc05a37730a79