New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ending database connection for tests #39

Open

matthewdking opened this issue Apr 20, 2018 · 0 comments

Labels

testing

Contributor

matthewdking commented Apr 20, 2018

This came up last week I think, when running tests it hangs afterwards as the connection to the db stays open.

Ensure dbConnection is required in to the test file

// using pg
tape.onFinish(() => {
  dbConnection.end()
})

// using pg-promise
tape.onFinish(() => {
  dbConnection.$pool.end()
})

matthewdking added the testing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment