Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fully encapsulating rejected execution handling #6867

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Feb 6, 2025

Description

throwing RejectedExecutionException was added to the SerialExecutor for consistency between the case when there was a local shutdown vs having the underlying executor shutdown. In every instance since then when this has come up we don't actually care about the work not being performed after shutdown - it's just a timing issue where we haven't check for shutdown prior to submitting the work. Rather than continue to change calling code, it seems better to just change the SerialExecutor contract and handle the rejections there.

closes: #6863

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@shawkins
Copy link
Contributor Author

shawkins commented Feb 6, 2025

Not sure about the flakey test here - nothing jumps out at me, and it does not seem reproducible.

@manusa
Copy link
Member

manusa commented Feb 7, 2025

There are a couple of flaky tests that I need to fix, don't worry.

@manusa manusa added this to the 7.2.0 milestone Feb 7, 2025 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit b6b66a1 into fabric8io:main Feb 7, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VertxWebSocket throws RejectedExecutionException after the client has shut down
2 participants