fix: fully encapsulating rejected execution handling #6867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
throwing RejectedExecutionException was added to the SerialExecutor for consistency between the case when there was a local shutdown vs having the underlying executor shutdown. In every instance since then when this has come up we don't actually care about the work not being performed after shutdown - it's just a timing issue where we haven't check for shutdown prior to submitting the work. Rather than continue to change calling code, it seems better to just change the SerialExecutor contract and handle the rejections there.
closes: #6863
Type of change
test, version modification, documentation, etc.)
Checklist