Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Validate script to identify location of the errors #148

Open
Preeticp opened this issue Dec 18, 2017 · 1 comment
Open

Enhancing Validate script to identify location of the errors #148

Preeticp opened this issue Dec 18, 2017 · 1 comment
Assignees
Labels
enhancement SEV4 Low priority. task New content or other non-bug work. tooling Build and validation scripts, Dockerfiles, etc.

Comments

@Preeticp
Copy link
Collaborator

Preeticp commented Dec 18, 2017

The Validate script is awesome for finding out errors. It could be even more useful, if it could identify the modules in which the errors are seen, reducing the time spent in searching for the error, especially when you tackle multiple modules in a PR.
For example: Processing e2e_workshop failed to build

asciidoctor: WARNING: invalid reference: reducing_project_memory_usage
asciidoctor: WARNING: invalid reference: reducing_project_memory_usage

Links used here were missing the context for the module being reused, but that was not obvious, nor was the location for these errors.

It would be great if we have a message like how we have for merge conflicts: CONFLICT (content): Merge conflict in docs/topics/modules/reviewing_resource_information_cli.adoc

Interim solution:
Run the following from the root of the repo:
grep -r reducing_project_memory_usage

@rkratky
Copy link
Collaborator

rkratky commented Dec 18, 2017

@rkratky rkratky self-assigned this Mar 12, 2018
@rkratky rkratky added the tooling Build and validation scripts, Dockerfiles, etc. label Mar 23, 2018
@rkratky rkratky added task New content or other non-bug work. SEV4 Low priority. labels Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement SEV4 Low priority. task New content or other non-bug work. tooling Build and validation scripts, Dockerfiles, etc.
Projects
None yet
Development

No branches or pull requests

2 participants