Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in the logging of Exceptions? #3706

Closed
MangelMaxime opened this issue Jan 22, 2024 · 3 comments · Fixed by #3709
Closed

Regression in the logging of Exceptions? #3706

MangelMaxime opened this issue Jan 22, 2024 · 3 comments · Fixed by #3709

Comments

@MangelMaxime
Copy link
Member

Description

With the rework of the logging system in #3671 exception message seems to not be formatted anymore.

CleanShot 2024-01-22 at 21 48 15

@nojaf Can the logging library used format the exception if one is happening inside of Fable?

The error seen in the screenshot comes from

then
failwithf
"Plugin %s expects v%s but currently running Fable v%s"
plugin.FullName
pluginInstance.FableMinimumVersion
Literals.VERSION

Related information

  • Fable version: 4.10.0
  • Operating system: OSX
@ncave
Copy link
Collaborator

ncave commented Jan 22, 2024

@MangelMaxime

Perhaps changing this line can fix it.

Update: Yes, it fixes the single-line exception issue, but it adds log level prefix on a separate line, so we need a custom logger to match the previous Fable log behavior.

@nojaf
Copy link
Member

nojaf commented Jan 23, 2024

I have an idea, and will look into it. Might be near end of the week though.

@MangelMaxime
Copy link
Member Author

Thanks you @ncave

You were faster than me, I saw your edit + PR while stilling working on my comment 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants