Inconsistency in Python import

[MangelMaxime]

Hello @dbrattli,

I am writing the documentation for Python on Fable website and found some strange behaviour.

I don't know if they are bugs or expected, as I am not a python expert.

I have a hello.py file with this content:

def say_hello():
    print("Hello world")

---

[<Import("say_hello", "./hello.py")>]
let say_hello : unit -> unit = jsNative

say_hello()

Generates

from hello import say_hello

say_hello()

So it means that it is stripping the ./ and .py from the path. However, using a relative path for * doesn't strip anything

[<Import("*", "./hello.py")>]
let say_hello : unit -> unit = jsNative

say_hello()

generates

import ./hello.py as say_hello

say_hello()

The same kind of problem occurs when trying to use:

• [<ImportAll("./hello.py")>]
• [<ImportDefault("./hello.py")>]

---

[<Import("*", "hello")>]
let say_hello : unit -> unit = jsNative

say_hello()

generates

import hello

hello()

This generates an error at runtime TypeError: 'module' object is not callable

I would have expected the generated code to be

from hello import *

say_hello()

---

[<ImportAll("hello")>]
let say_hello : unit -> unit = jsNative

generates

import hello

hello()

Should it be ?

from hello import *

say_hello()

---

[<ImportAll("./hello.py")>]
let say_hello : unit -> unit = jsNative

generates

import ./hello.py as hello

hello()

Should it strip the path?

Also, generated code doesn't work because it tries to execute the module instead of hello.say_hello()

---

[<ImportDefault("./hello.py")>]
let say_hello : unit -> unit = jsNative

say_hello()

generates

from hello import hello

hello()

The code will fail at runtime, but I don't know what is the expected output here.

but

[<ImportDefault("hello")>]
let say_hello : unit -> unit = jsNative

say_hello()

generates

import hello

hello()

Is it normal to have a difference here? And the code will fails to, but I don't know what is the expected output here.

Related information

• Fable version: 4.1.4
• Operating system

[MangelMaxime]

let hi : unit -> unit = import "*" "./hello.py"

hi()

generates

from typing import Callable
import ./hello.py as hello

hi: Callable[[], None] = hello

hi()

which is an invalid code.

---

let say_hello : unit -> unit = importAll "hello"

say_hello()

generates

import hello
from typing import Callable

say_hello: Callable[[], None] = hello

say_hello()

I think it should generates

from hello import * 
from typing import Callable

say_hello()

or

from hello import * 
from typing import Callable

say_hello_1: Callable[[], None] = say_hello

say_hello_1()

if we need the variable assignement.

[joprice]

There's also an issue with importSideEffects, which generates from X import without any identifier following the import statement, which is invalid syntax.

[alfonsogarciacaro]

Should be fixed by #4035

Not sure if from hello import * as this will put all imported members in the current namespace and it will make it very difficult for Fable to prevent name conflicts.